CHANGELOG
Changelog for package rcl_action
10.0.2 (2025-01-31)
fix(rcl_action): Allow to pass the timer to action during initialization (#1201) * fix(timer): Use impl pointer in jump callback The interface description does not explicitly state that a rcl_timer_t may not be copied around. Therefore users may do this. By using a known never changing pointer in the callbacks, we avoid segfaults, even if the ‘user’ decides to copy the rcl_timer_t around.
Added remapping resolution for action names (#1170) * Added remapping resolution for action names * Fix cpplint/uncrustify * Simplified returned error codes in case name resolution failes. * Renamed action_name field to remapped_action_name. * Removed unnecessary resolved_action_name stack variable * Added tests for action name remapping. * Add tests for action name remapping using local arguments ———
Clean up error handling in many rcl{_action,_lifecycle} codepaths (#1202) * Shorten the delay in test_action_server setup. Instead of waiting 250ms between setting up 10 goals (for at least 2.5 seconds), just wait 100ms which reduces this to 1 second. * Small style cleanups in test_action_server.cpp * Reset the error in rcl_node_type_cache_register_type(). That is, if rcutils_hash_map_set() fails, it sets its own error, so overriding it with our own will cause a warning to print. Make sure to clear it before setting our own. * Only unregister a clock jump callback if we have installed it. This avoids a warning on cleanup in rcl_timer_init2. * Record the return value from rcl_node_type_cache_register_type. Otherwise, in a failure situation we set the error but we actually return RCL_RET_OK to the upper layers, which is odd. * Get rid of completely unnecessary return value translation. This generated code was translating an RCL error to an RCL error, which doesn’t make much sense. Just remove the duplicate code. * Use the rcl_timer_init2 functionality to start the timer disabled. Rather than starting it enabled, and then immediately canceling it. * Don’t overwrite the error from rcl_action_goal_handle_get_info() It already sets the error, so rcl_action_server_goal_exists() should not set it again. * Reset errors before setting new ones when checking action validity That way we avoid an ugly warning in the error paths. * Move the copying of the options earlier in rcl_subscription_init. That way when we go to cleanup in the “fail” case, the options actually exist and are valid. This avoids an ugly warning during cleanup. * Make sure to set the error on failure of rcl_action_get_##_service_name This makes it match the generated code for the action_client. * Reset the errors during RCUTILS_FAULT_INJECTION testing. That way subsequent failures won’t print out ugly error strings. * Make sure to return errors in _rcl_parse_resource_match . That is, if rcl_lexer_lookahead2_expect() returns an error, we should pass that along to higher layers rather than just ignoring it. * Don’t overwrite error by rcl_validate_enclave_name. It leads to ugly warnings. * Add acomment that rmw_validate_namespace_with_size sets the error * Make sure to reset error in rcl_node_type_cache_init. Otherwise we get a warning about overwriting the error from rcutils_hash_map_init. * Conditionally set error message in rcl_publisher_is_valid. Only when rcl_context_is_valid doesn’t set the error. * Don’t overwrite error from rcl_node_get_logger_name. It already sets the error in the failure case. * Make sure to reset errors when testing network flow endpoints. That’s because some of the RMW implementations may not support this feature, and thus set errors. * Make sure to reset errors in rcl_expand_topic_name. That way we can set more useful errors for the upper layers. * Cleanup wait.c error handling. In particular, make sure to not overwrite errors as we get into error-handling paths, which should clean up warnings we get. * Make sure to reset errors in rcl_lifecycle tests. That way we won’t get ugly “overwritten” warnings on subsequent tests. ———
Contributors: Chris Lalancette, Janosch Machowinski, Justus Braun
10.0.1 (2024-11-20)
10.0.0 (2024-10-03)
Cleanup test_graph.cpp. (#1193)
Expect a minimum of two nodes to be alive in test_graph (#1192)
escalate RCL_RET_ACTION_xxx to 40XX. (#1191)
Fix NULL allocator and racy condition. (#1188)
Increased timeouts (#1181)
Change the starting time of the goal expiration timeout (#1121)
Contributors: Alejandro Hernández Cordero, Barry Xu, Chris Lalancette, Tomoya Fujita, Yadu
9.4.1 (2024-07-29)
Increase the test_action_interaction timeouts. (#1172) While I can’t reproduce the problem locally, I suspect that waiting only 1 second for the entities to become ready isn’t enough in all cases, particularly on Windows, with Connext, and when we are running in parallel with other tests. Thus, increase the timeout for the rcl_wait() in all of the test_action_interaction tests, which should hopefully be enough to make this always pass.
Stop compiling rcl_action tests multiple times. (#1165) We don’t need to compile the tests once for each RMW; we can just compile it once and then use the RMW_IMPLEMENTATION environment variable to run the tests on the different RMWs. This speeds up compilation.
Contributors: Chris Lalancette
9.4.0 (2024-06-17)
9.3.0 (2024-04-26)
9.2.1 (2024-04-16)
Generate version header using ament_generate_version_header(..) (#1141)
Contributors: G.A. vd. Hoorn
9.2.0 (2024-03-28)
9.1.0 (2024-01-24)
9.0.0 (2023-12-26)
8.0.0 (2023-11-06)
7.3.0 (2023-10-09)
7.2.0 (2023-10-04)
Remove most remaining uses of ament_target_dependencies. (#1102)
Contributors: Chris Lalancette
7.1.1 (2023-09-07)
7.1.0 (2023-08-21)
7.0.0 (2023-07-11)
6.3.0 (2023-06-12)
6.2.0 (2023-06-07)
6.1.1 (2023-05-11)
6.1.0 (2023-04-28)
6.0.1 (2023-04-18)
6.0.0 (2023-04-12)
doc update, ROS message accessibility depends on RMW implementation. (#1043)
Contributors: Tomoya Fujita
5.9.0 (2023-03-01)
5.8.0 (2023-02-23)
5.7.0 (2023-02-13)
Update rcl to C++17. (#1031)
Contributors: Chris Lalancette
5.6.0 (2022-12-05)
5.5.0 (2022-11-02)
5.4.1 (2022-09-13)
5.4.0 (2022-04-29)
5.3.1 (2022-04-26)
5.3.0 (2022-04-05)
5.2.1 (2022-03-31)
5.2.0 (2022-03-24)
5.1.0 (2022-03-01)
5.0.1 (2022-01-14)
5.0.0 (2021-12-14)
Fix up documentation build for rcl_action when using rosdoc2 (#937)
Contributors: Michel Hidalgo
4.0.0 (2021-09-16)
Fix expired goals capacity of action server (#931)
Contributors: spiralray
3.2.0 (2021-09-02)
Wait for action server in rcl_action comm tests. (#919)
Contributors: Michel Hidalgo
3.1.2 (2021-04-26)
3.1.1 (2021-04-12)
3.1.0 (2021-04-06)
updating quality declaration links (re: ros2/docs.ros2.org#52) (#909)
Contributors: shonigmann
3.0.1 (2021-03-25)
3.0.0 (2021-03-23)
2.6.0 (2021-03-18)
2.5.2 (2021-02-05)
Avoid setting error message twice. (#887)
Contributors: Chen Lihui
2.5.1 (2021-01-25)
2.5.0 (2020-12-08)
2.4.0 (2020-10-19)
Make sure to check the return value of rcl APIs. (#838)
Contributors: Chris Lalancette
2.3.0 (2020-10-19)
2.2.0 (2020-09-02)
2.1.0 (2020-07-22)
2.0.0 (2020-07-09)
Update quality declaration and coverage (#674)
Contributors: Alejandro Hernández Cordero
1.2.0 (2020-06-18)
Fixed doxygen warnings (#677)
Contributors: Alejandro Hernández Cordero
1.1.5 (2020-06-03)
1.1.4 (2020-06-02)
1.1.3 (2020-06-01)
1.1.2 (2020-05-28)
1.1.1 (2020-05-26)
1.1.0 (2020-05-22)
Update Quality Declaration for 1.0 (#647)
Contributors: Stephen Brawner
1.0.0 (2020-05-12)
0.9.1 (2020-05-08)
0.9.0 (2020-04-29)
Export targets in a addition to include directories / libraries (#632)
Rename rosidl_generator_c namespace to rosidl_runtime_c (#616)
Rename rosidl_generator_cpp namespace to rosidl_runtime_cpp (#615)
Changed rosidl_generator_c/cpp to rosidl_runtime_c/cpp (#588)
Changed build_depend and build_depend_export dependencies to depend (#577)
Code style only: wrap after open parenthesis if not in one line (#565)
Check if action status publisher is ready (#541)
Contributors: Alejandro Hernández Cordero, Dirk Thomas, Tomoya Fujita
0.8.3 (2019-11-08)
0.8.2 (2019-10-23)
0.8.1 (2019-10-08)
0.8.0 (2019-09-26)
0.7.4 (2019-05-29)
rcl_action - user friendly error messages for invalid transitions (#448)
Contributors: Siddharth Kucheria
0.7.3 (2019-05-20)
Fixed memory leaks in
rcl_action
unit tests (#442)Contributors: Prajakta Gokhale
0.7.2 (2019-05-08)
0.7.1 (2019-04-29)
0.7.0 (2019-04-14)
Added Action graph API (#411)
Updated to use ament_target_dependencies where possible. (#400)
Fixed typo in Doxyfile. (#398)
Updated tests to use separated action types. (#340)
Fixed minor documentation issues. (#397)
Set symbol visibility to hidden for rcl. (#391)
Fixed rcl_action documentation. (#380)
Removed now unused test executable . (#382)
Removed unused action server option ‘clock_type’. (#382)
Set error message when there is an invalid goal transition. (#382)
Updated to pass context to wait set, and fini rmw context (#373)
Contributors: Dirk Thomas, Jacob Perron, Sachin Suresh Bhat, William Woodall, ivanpauno
0.6.4 (2019-01-11)
0.6.3 (2018-12-13)
0.6.2 (2018-12-13)
[rcl_action] Bugfix: arithmetic error
Contributors: Jacob Perron
0.6.1 (2018-12-07)
Added wait_for_action_server() for action clients (#349)
Updated to adapt to action implicit changes (#353)
Added action interaction tests (#352)
Enabled test_action_communication to compile against available rmw. (#351)
Changed UUID type in action msgs (#338)
Added rcl_action_server_is_valid_except_context (#348)
Updated to fini even if node context is invalid and reset error (#346)
Added timer to action server to check expired goals + asan fixes (#343)
Increased timeout for rcl_wait in action tests (#344)
Refactored init to not be global (#336)
Completes integration tests for action client/server (#331)
Updated rcl_action_expire_goals() to output list of expired goals. (#342)
Updated process_cancel_request to no longer change goal state (#341)
Add action server implementation (#323)
Contributors: Alexis Pojomovsky, Jacob Perron, Michel Hidalgo, Shane Loretz, William Woodall
0.6.0 (2018-11-16)
Made rcl_action_get_*_name() functions check for empty action names. #329
Implemented Action client #319
Added function to check if goal can be transitioned to CANCELING (#325)
Implement goal handle (#320)
Update to use new error handling API from rcutils (#314)
Add action services and topics name getters #317
Implement init/fini functions for types (#312)
Refactor goal state machine implementation and add unit tests (#311)
Add missing visibilty control definitions (#315)
Add rcl_action package and headers (#307)
Contributors: Jacob Perron, Michel Hidalgo, William Woodall